🐛 wrong condition in lobby in memory on finding room by id

Ragon.Client/Sources/Entity/RagonProperty.cs

@@ -30,7 +30,7 @@ namespace Ragon.Client
     public int Size => _size;
 
     private RagonBuffer _propertyBuffer;
-    private RagonEntity _entity;    
+    private RagonEntity _entity;
     private bool _dirty;
     private int _size;
     private int _ticks;
@@ -46,7 +46,7 @@ namespace Ragon.Client
       _priority = priority;
       _fixed = false;
       _propertyBuffer = new RagonBuffer();
-      
+
       InvokeLocal = invokeLocal;
     }
 
@@ -63,16 +63,17 @@ namespace Ragon.Client
 
     protected void InvokeChanged()
     {
-      if (!InvokeLocal)
+      if (_entity.HasAuthority)
         return;
-      
+
       Changed?.Invoke();
     }
 
     protected void MarkAsChanged()
     {
-      InvokeChanged();
+      if (InvokeLocal)
-
+        Changed?.Invoke();
+      
       if (_dirty || _entity == null)
         return;
 
@@ -101,34 +102,34 @@ namespace Ragon.Client
     internal void Write(RagonBuffer buffer)
     {
       _propertyBuffer.Clear();
-      
+
       if (_fixed)
       {
         Serialize(_propertyBuffer);
-        
+
         buffer.CopyFrom(_propertyBuffer, _size);
         return;
       }
 
       Serialize(_propertyBuffer);
 
-      var propertySize = (ushort) _propertyBuffer.WriteOffset;
+      var propertySize = (ushort)_propertyBuffer.WriteOffset;
-      buffer.WriteUShort(propertySize);;
+      buffer.WriteUShort(propertySize);
       buffer.CopyFrom(_propertyBuffer, propertySize);
     }
 
     internal void Read(RagonBuffer buffer)
     {
       _propertyBuffer.Clear();
-      
+
       if (_fixed)
       {
         buffer.ToBuffer(_propertyBuffer, _size);
-        
+
         Deserialize(_propertyBuffer);
         return;
       }
-      
+
       var propSize = buffer.ReadUShort();
       buffer.ToBuffer(_propertyBuffer, propSize);
       Deserialize(_propertyBuffer);

Ragon.Server/Sources/Lobby/RagonLobbyInMemory.cs

@@ -25,12 +25,20 @@ public class LobbyInMemory : IRagonLobby
   private readonly List<RagonRoom> _rooms = new();
   private readonly Logger _logger = LogManager.GetCurrentClassLogger();
 
-  public bool FindRoomById(string RagonRoomId, [MaybeNullWhen(false)] out RagonRoom room)
+  public bool FindRoomById(string roomId, [MaybeNullWhen(false)] out RagonRoom room)
   {
     foreach (var existRagonRoom in _rooms)
     {
-      if (existRagonRoom.Id == RagonRoomId && existRagonRoom.PlayerMin < existRagonRoom.PlayerMax)
+      if (existRagonRoom.Id == roomId)
       {
+        if (existRagonRoom.PlayerCount >= existRagonRoom.PlayerMax)
+        {
+          _logger.Warn($"Room with id {roomId} fulfilled");
+          
+          room = default;
+          return false;
+        }
+        
         room = existRagonRoom;
         return true;
       }
@@ -44,8 +52,16 @@ public class LobbyInMemory : IRagonLobby
   {
     foreach (var existsRoom in _rooms)
     {
-      if (existsRoom.Scene == sceneName && existsRoom.PlayerCount < existsRoom.PlayerMax)
+      if (existsRoom.Scene == sceneName)
       {
+        if (existsRoom.PlayerCount >= existsRoom.PlayerMax)
+        {
+          _logger.Warn($"Room with scene {sceneName} fulfilled");
+          
+          room = default;
+          return false;          
+        }
+        
         room = existsRoom;
         return true;
       }